BUGFIX: template-require-mandatory-role-attributes — lowercase role + split whitespace role lists#2728
Draft
johanrd wants to merge 8 commits intoember-cli:masterfrom
Draft
Conversation
…t whitespace-separated role lists
Two changes, shared root cause (both deal with role-token normalisation).
1. Case-insensitive role matching. Per HTML-AAM, ARIA role tokens
compare as ASCII-case-insensitive. Before: <div role="COMBOBOX">
was silently accepted because "COMBOBOX" didn't match "combobox" in
aria-query. Now: lowercase before lookup.
2. Whitespace-separated role fallback lists. Per ARIA 1.2 §5.4, a role
attribute may list multiple tokens to express a fallback; a UA picks
the first one it recognises. Before: role="combobox listbox" was
treated as one opaque string, aria-query returned undefined, and
the rule skipped silently. Now: split on whitespace, check against
the first recognised role's required attributes (matching jsx-a11y).
Helpers renamed to plural forms (getStaticRolesFromElement,
getStaticRolesFromMustache) and getMissingRequiredAttributes now
returns { role, missing } so the reporter can use the actually-checked
role in the error message.
Four new tests cover the two cases (valid + invalid of each).
…back semantics The previous comment said this matched jsx-a11y, but jsx-a11y validates every recognised role token while we check only the first recognised role per ARIA role-fallback semantics. Update the comment to reflect the PR description's stated behavior.
…er cases
Translates 33 cases from peer-plugin rules:
- jsx-a11y role-has-required-aria-props
- vuejs-accessibility role-has-required-aria-props
- @angular-eslint/template role-has-required-aria
- lit-a11y role-has-required-aria-attrs
Fixture documents parity after this fix:
- Case-insensitive role comparison (<div role="COMBOBOX"> flagged).
- Whitespace-separated roles: first recognised token is validated
(ARIA 1.2 §4.1 role-fallback semantics). Divergence from jsx-a11y,
which validates every recognised token; documented inline.
The semantic input+role exception (input[type=checkbox] role=switch)
remains flagged here — that fix is on a separate branch.
johanrd
added a commit
to johanrd/eslint-plugin-ember
that referenced
this pull request
Apr 21, 2026
…d exemption to {{input}} helper
Two changes:
1. `getInputType` now recognises the classic Ember `{{input type=...}}`
helper as an input host, in addition to the native `<input>` element.
The `GlimmerMustacheStatement` handler is updated to pass `node` into
`getMissingRequiredAttributes`, matching the element-node handler.
2. Reverts the defensive `role.toLowerCase()` in the whitelist-key build
from the previous commit — it was dead code. The caller
(`getMissingRequiredAttributes`) short-circuits via aria-query's
case-sensitive `roles.get(role)`, so `role` is guaranteed lowercase
by the time `isNativelyChecked` runs. Rule-wide role case-
insensitivity is not in scope for this PR; that is ember-cli#2728.
Tests adjusted accordingly: drop mixed-case-role valid tests (they
passed for the wrong reason — via the case-sensitivity short-circuit in
aria-query, not via the whitelist). Add coverage for `{{input}}`
helper on both gts and hbs parsers, including off-whitelist pairings
that must still flag.
This was referenced Apr 21, 2026
Draft
… review) - Add HBS equivalents of the GJS case-insensitive and role-fallback tests so both parser paths exercise the same behaviours. - Sort missingRequiredAttributes alphabetically so report order is stable regardless of aria-query's requiredProps iteration order.
…quiredAttributeErrorMessage The helper was unused after the messageId migration (the rule now uses aria-query-derived data + `messages.missingRequired` with a parameterized template). No references remained in the rule or its test file.
johanrd
force-pushed
the
fix/role-required-aria-case-and-space-split
branch
from
88ab040 to
3d69b55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related fixes (shared root cause — both deal with role-token normalisation).
1. Case-insensitive role comparison
role="COMBOBOX"is the same token asrole="combobox". (WAI-ARIA 1.2 §4.1 explicitly defers case-sensitivity to the host language: "Case-sensitivity of the comparison inherits from the case-sensitivity of the host language.")<div role="COMBOBOX">was silently accepted —roles.get("COMBOBOX")returns undefined inaria-query, so the rule skipped the check entirely.Fix: lowercase the role value before the lookup.
2. Whitespace-separated role fallback lists
roleattribute may list multiple tokens and "User agents MUST use the first token in the sequence of tokens in the role attribute value that matches the name of any non-abstract WAI-ARIA role."role="combobox listbox"was treated as one opaque string.aria-queryreturned undefined, the rule skipped silently, and<div role="combobox listbox">withoutaria-expanded+aria-controlswasn't flagged.Fix: split on whitespace, validate the first recognised role per ARIA §4.1's first-token semantics. This diverges from jsx-a11y and vue-a11y, which validate every recognised token — our approach is closer to the UA behavior the spec prescribes. Noted as a deliberate divergence.
Helpers renamed to plural forms (
getStaticRolesFromElement,getStaticRolesFromMustache).getMissingRequiredAttributesnow returns{ role, missing }so the reporter can cite the actually-checked role in the error message.Four new tests cover both fixes (valid + invalid of each).
Prior art
Verified each peer in source:
role-has-required-aria-propsString(roleAttrValue).toLowerCase().split(' ')→.filter(recognised)→.forEach(validate). Validates EVERY recognised token.role-has-required-aria-propsroleValue.toLowerCase().split(" ").forEach(role => { if (isAriaRoleDefinitionKey(role)) validate(role) }). Same pattern.role-has-required-ariaroles.get(role). No.toLowerCase(), no.split().role-has-required-aria-attrsisAriaRole/roles.get. No splitting, no lowercasing.